Skip to content
NewSee how fast an edit goes live on this site
Halftone

EngineeringInfrastructure

What we learned rewriting feature flags, part 2

What changed when we stopped guessing and started measuring every step.

Kit Moreau / Dee Marsh
Published 2 min read

Caching is easy to add and hard to trust. The rule we settled on is simple: a cache key must include everything that can change the output, and nothing that cannot. This post covers what we changed, why, and what it means for you.

#The details

None of this needed a new framework. It needed a clear owner, a dashboard people actually looked at, and permission to delete code that no longer earned its keep.

We started by measuring instead of guessing. Every step got a timer, every run wrote its numbers to a table, and within a week the picture was clear: most of the time went to setup, not to the work itself.

For most of last year, a full build took eleven minutes. Nobody decided that was acceptable; it simply grew there, one dependency and one test suite at a time, until waiting became part of the job.

“Measure the time from done to live, and treat every minute of it as a bug.”
Fen Alvarez

#Where we started

The part we underestimated was rollback. A faster pipeline is only better if you can undo it just as fast, so every deploy now keeps the previous version warm and one click away.

We kept the old path running next to the new one for two weeks and compared outputs byte for byte. Most differences were harmless. Three were real bugs that the old path had been hiding for years.

#What we would do differently

Latency at the median improved, but the tail is what people feel. Our p95 dropped from 4.1 seconds to 900 milliseconds, and support tickets about slowness fell by more than half.

The fix was less clever than we expected. We cached what never changes, skipped what had not changed, and stopped doing work in series that could happen side by side.

Caching is easy to add and hard to trust. The rule we settled on is simple: a cache key must include everything that can change the output, and nothing that cannot.

Diagram of the request path before and after the change
Figure: the request path, before and after.

#Trade-offs

None of this needed a new framework. It needed a clear owner, a dashboard people actually looked at, and permission to delete code that no longer earned its keep.

We started by measuring instead of guessing. Every step got a timer, every run wrote its numbers to a table, and within a week the picture was clear: most of the time went to setup, not to the work itself.

For most of last year, a full build took eleven minutes. Nobody decided that was acceptable; it simply grew there, one dependency and one test suite at a time, until waiting became part of the job.

“Good defaults are invisible until they are missing.”
Cam Okafor