Skip to content
NewSee how fast an edit goes live on this site
Halftone

EngineeringPerformance

How we rebuilt search indexing, part 2

What changed when we stopped guessing and started measuring every step.

Lu Brandt / Dee Marsh
Published 2 min read

The part we underestimated was rollback. A faster pipeline is only better if you can undo it just as fast, so every deploy now keeps the previous version warm and one click away. This post covers what we changed, why, and what it means for you.

#Trade-offs

Latency at the median improved, but the tail is what people feel. Our p95 dropped from 4.1 seconds to 900 milliseconds, and support tickets about slowness fell by more than half.

We started by measuring instead of guessing. Every step got a timer, every run wrote its numbers to a table, and within a week the picture was clear: most of the time went to setup, not to the work itself.

For most of last year, a full build took eleven minutes. Nobody decided that was acceptable; it simply grew there, one dependency and one test suite at a time, until waiting became part of the job.

#What we would do differently

The fix was less clever than we expected. We cached what never changes, skipped what had not changed, and stopped doing work in series that could happen side by side.

Caching is easy to add and hard to trust. The rule we settled on is simple: a cache key must include everything that can change the output, and nothing that cannot.

“Good defaults are invisible until they are missing.”
Dee Marsh

#Rolling it out

We kept the old path running next to the new one for two weeks and compared outputs byte for byte. Most differences were harmless. Three were real bugs that the old path had been hiding for years.

None of this needed a new framework. It needed a clear owner, a dashboard people actually looked at, and permission to delete code that no longer earned its keep.

The part we underestimated was rollback. A faster pipeline is only better if you can undo it just as fast, so every deploy now keeps the previous version warm and one click away.

Diagram of the request path before and after the change
Figure: the request path, before and after.

#What changed

Latency at the median improved, but the tail is what people feel. Our p95 dropped from 4.1 seconds to 900 milliseconds, and support tickets about slowness fell by more than half.

We started by measuring instead of guessing. Every step got a timer, every run wrote its numbers to a table, and within a week the picture was clear: most of the time went to setup, not to the work itself.

For most of last year, a full build took eleven minutes. Nobody decided that was acceptable; it simply grew there, one dependency and one test suite at a time, until waiting became part of the job.

Diagram of the request path before and after the change
Figure: the request path, before and after.